break PREFIX into PREFIX_PACKAGE and PREFIX_INSTALL, to fix the path … #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when building debian packages as a non-root user.
fisx
reviewed
Jan 23, 2019
| @@ -19,7 +21,7 @@ all: build | |||
| clean: | |||
| cargo clean | |||
| rm -rf test/target | |||
| rm -rf deb$(PREFIX)/ | |||
There was a problem hiding this comment.
don't we want to clean both here?
There was a problem hiding this comment.
cleaning an install (which is what prefix_install is for) would be performing an uninstall. the install rule places results directly on the filesystem, not in a temporary location, so it does not need cleaned up after.
fisx
approved these changes
Jan 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when building debian packages as a non-root user.