Cleanup logging #816
Merged
Cleanup logging #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasn't possible to do everywhere given Session isn't an instance of UnlftIO
This allows us to use the classy logger in proxy
This will make it easy for us to inject global information into the logs consistently everywhere
fisx
approved these changes
Aug 6, 2019
Co-Authored-By: fisx <mf@zerobuzz.net>
Co-Authored-By: fisx <mf@zerobuzz.net>
Co-Authored-By: fisx <mf@zerobuzz.net>
Co-Authored-By: fisx <mf@zerobuzz.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure that we were using the
MonadLoggertypeclass everywhere, as this will make it easy to consistently inject metadata into the logs throughout the project.Turns out, most places where already fine.
I made this PR by using
sedand then making stuff compile. So maybe some places we could have left untouched. We should go over the diff and decide what things do not need to be changed, such that the diff becomes a bit smaller