-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better events for deletion of team conversations #849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I go to line 742 in
or
|
fisx
changed the title
[WIP] Better events for deletion of team conversations
Better events for deletion of team conversations
Sep 10, 2019
tiago-loureiro
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge assuming it passes CI tests
Merged
jschaul
added a commit
that referenced
this pull request
Nov 4, 2019
Events about deleted conversations do not need to be sent to everyone when a team is deleted. Indeed, it is harmful in that it leads to performance problems: For large teams with many conversations, notifying every team member about that fact that every conversation has been deleted creates a lot of events. None of these events are useful, since on a team deletion, the accounts of every user are deleted, i.e. in practice these events cannot be read. This PR fixes the bug that was introduced in #849
jschaul
added a commit
that referenced
this pull request
Nov 4, 2019
Events about deleted conversations do not need to be sent to everyone when a team is deleted. Indeed, it is harmful in that it leads to performance problems: For large teams with many conversations, notifying every team member about that fact that every conversation has been deleted creates a lot of events. None of these events are useful, since on a team deletion, the accounts of every user are deleted, i.e. in practice these events cannot be read. This PR fixes the bug that was introduced in #849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start sending
conversation.delete
event also to all team members (whether in the conversation or not).team.conversation-delete
will still be sent as before.This solves the following issue:
Also, lots of small refactoring.