feat: Show warning when receiving call with outdated client (#8798)

wireapp · May 14, 2020 · 00d3d12 · 00d3d12
1 parent d6d2424
commit 00d3d12
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/i18n/en-US.json b/src/i18n/en-US.json
@@ -601,6 +601,8 @@
   "modalCallSecondOutgoingAction": "Call Anyway",
   "modalCallSecondOutgoingHeadline": "Hang up current call?",
   "modalCallSecondOutgoingMessage": "A call is active in another conversation. Calling here will hang up the other call.",
+  "modalCallUpdateClientHeadline": "Please update {{brandName}}",
+  "modalCallUpdateClientMessage": "You received a call that isn't supported by this version of {{brandName}}.",
   "modalConfirmSecondary": "Cancel",
   "modalConnectAcceptAction": "Connect",
   "modalConnectAcceptHeadline": "Accept?",

diff --git a/src/script/calling/CallingRepository.ts b/src/script/calling/CallingRepository.ts
@@ -30,6 +30,7 @@ import {
   STATE as CALL_STATE,
   VIDEO_STATE,
   Wcall,
+  ERROR,
 } from '@wireapp/avs';
 import {Calling, GenericMessage} from '@wireapp/protocol-messaging';
 import {WebAppEvents} from '@wireapp/webapp-events';
@@ -382,6 +383,15 @@ export class CallingRepository {
 
       if (res !== 0) {
         this.logger.warn(`recv_msg failed with code: ${res}`);
+        if (res === ERROR.UNKNOWN_PROTOCOL) {
+          const brandName = Config.getConfig().BRAND_NAME;
+          amplify.publish(WebAppEvents.WARNING.MODAL, ModalsViewModel.TYPE.ACKNOWLEDGE, {
+            text: {
+              message: t('modalCallUpdateClientMessage', brandName),
+              title: t('modalCallUpdateClientHeadline', brandName),
+            },
+          });
+        }
         return;
       }
       this.handleCallEventSaving(content.type, conversationId, userId, time, source);

diff --git a/src/script/conversation/ConversationRepository.js b/src/script/conversation/ConversationRepository.js
@@ -2857,7 +2857,7 @@ export class ConversationRepository {
     return this.grantMessage(eventInfoEntity, consentType, userIds);
   }
 
-  grantMessage(eventInfoEntity, consentType, userIds, shouldShowLegalHoldWarning = false) {
+  grantMessage(eventInfoEntity, consentType, userIds = null, shouldShowLegalHoldWarning = false) {
     return this.get_conversation_by_id(eventInfoEntity.conversationId).then(conversationEntity => {
       const legalHoldMessageTypes = [
         GENERIC_MESSAGE_TYPE.ASSET,