-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move acc changes to dev #13608
Changes from all commits
c867130
9cb421d
ed005a2
cd0978d
52185cb
6bc076f
c458ff9
0708533
efde89d
ade9404
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ | |
<arrow-left-icon aria-hidden="true"></arrow-left-icon> | ||
</button> | ||
<h3 class="panel__header__title" data-bind="text: headerText" data-uie-name="status-people-selected"></h3> | ||
<button class="right-panel-close icon-button" type="button" data-bind="clickOrDrag: onClose, attr: { title: t('accessibility.rightPanel.close'), 'aria-label': t('accessibility.rightPanel.close')}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. needs to be ported to React in the future |
||
<button class="right-panel-close icon-button" type="button" data-bind="clickOrDrag: onClose, attr: { 'aria-label': t('accessibility.addParticipants.close')}" | ||
data-uie-name="do-close"> | ||
<close-icon aria-hidden="true"></close-icon> | ||
</button> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
<!-- ko if: isVisible() --> | ||
<div class="panel__header"> | ||
<button class="icon-button" type="button" | ||
data-bind="clickOrDrag: onGoBack, attr: { title: t('accessibility.rightPanel.GoBack'), 'aria-label': t('accessibility.rightPanel.GoBack') }" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. needs to be ported to the react component in the future |
||
data-bind="clickOrDrag: onGoBack, attr: { title: t('accessibility.rightPanel.GoBack'), 'aria-label': t('accessibility.conversation.goBack') }" | ||
data-uie-name="go-back-conversation-participants"> | ||
<arrow-left-icon aria-hidden="true"></arrow-left-icon> | ||
</button> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
<!-- ko if: isVisible() --> | ||
<div class="panel__header"> | ||
<button type="button" class="icon-button" | ||
data-bind="clickOrDrag: onGoBack, attr: { title: t('accessibility.rightPanel.GoBack'), 'aria-label': t('accessibility.rightPanel.GoBack') }" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do forget to port those changes to the corresponding React component when it is created (ping @przemvs in case you are working on this file) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @arjita-mitra actually already commentd that on the last migration PR, she's on top of this :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚀 |
||
data-bind="clickOrDrag: onGoBack, attr: { title: t('accessibility.rightPanel.GoBack'), 'aria-label': t('accessibility.conversation.goBack') }" | ||
data-uie-name="go-back-group-participant"> | ||
<arrow-left-icon aria-hidden="true"></arrow-left-icon> | ||
</button> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to be ported to React in the future