Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate AddParticipants to React #13614

Merged
merged 5 commits into from
Sep 9, 2022
Merged

refactor: migrate AddParticipants to React #13614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d91cdba
refactor: migrate AddParticipants to React
przemvs Sep 6, 2022
26354f0
Merge branch 'refactor/migrate-right-sidebar-to-react' into refactor/…
przemvs Sep 7, 2022
c5cbd07
Merge branch 'refactor/migrate-right-sidebar-to-react' into refactor/…
przemvs Sep 8, 2022
a4e50f3
Replace useCallback with useMemo
przemvs Sep 8, 2022
30ce5bc
Merge branch 'refactor/migrate-right-sidebar-to-react' into refactor/…
przemvs Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions .betterer.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2452,17 +2452,17 @@ exports[`stricter compilation`] = {
[297, 34, 29, "Argument of type \'boolean | undefined\' is not assignable to parameter of type \'boolean\'.\\n Type \'undefined\' is not assignable to type \'boolean\'.", "1283406094"],
[340, 19, 4, "Argument of type \'null\' is not assignable to parameter of type \'string\'.", "2087897566"]
],
"src/script/view_model/PanelViewModel.ts:733658666": [
[61, 2, 13, "Property \'currentEntity\' has no initializer and is not definitely assigned in the constructor.", "32305655"],
[118, 4, 23, "Type \'Observable<Conversation | null>\' is not assignable to type \'Observable<Conversation>\'.", "2356679995"],
[122, 4, 10, "Type \'Observable<string | undefined>\' is not assignable to type \'Observable<string>\'.", "4014904506"],
[124, 4, 17, "Type \'Observable<string | undefined>\' is not assignable to type \'Observable<string>\'.", "2911337818"],
[192, 15, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'string\'.", "2620553983"],
[194, 4, 18, "Type \'undefined\' is not assignable to type \'PanelEntity\'.", "2173061407"],
[259, 22, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'string\'.", "2620553983"],
[279, 24, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'string\'.", "2620553983"],
[280, 34, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'string\'.", "2620553983"],
[292, 6, 15, "Type \'Element | null\' is not assignable to type \'Element | undefined\'.\\n Type \'null\' is not assignable to type \'Element | undefined\'.", "2931287914"]
"src/script/view_model/PanelViewModel.ts:1300556289": [
[60, 2, 13, "Property \'currentEntity\' has no initializer and is not definitely assigned in the constructor.", "32305655"],
[115, 4, 23, "Type \'Observable<Conversation | null>\' is not assignable to type \'Observable<Conversation>\'.", "2356679995"],
[119, 4, 10, "Type \'Observable<string | undefined>\' is not assignable to type \'Observable<string>\'.", "4014904506"],
[121, 4, 17, "Type \'Observable<string | undefined>\' is not assignable to type \'Observable<string>\'.", "2911337818"],
[189, 15, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'string\'.", "2620553983"],
[191, 4, 18, "Type \'undefined\' is not assignable to type \'PanelEntity\'.", "2173061407"],
[256, 22, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'string\'.", "2620553983"],
[276, 24, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'string\'.", "2620553983"],
[277, 34, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'string\'.", "2620553983"],
[289, 6, 15, "Type \'Element | null\' is not assignable to type \'Element | undefined\'.\\n Type \'null\' is not assignable to type \'Element | undefined\'.", "2931287914"]
],
"src/script/view_model/WindowTitleViewModel.ts:2939646455": [
[48, 4, 17, "Type \'Observable<ContentState>\' is not assignable to type \'Observable<string>\'.\\n Types of parameters \'value\' and \'value\' are incompatible.\\n Type \'string\' is not assignable to type \'ContentState\'.", "3516467027"],
Expand Down Expand Up @@ -2513,12 +2513,6 @@ exports[`stricter compilation`] = {
[355, 68, 6, "Type \'string | undefined\' is not assignable to type \'string\'.\\n Type \'undefined\' is not assignable to type \'string\'.", "1127975365"],
[358, 14, 5, "Object is of type \'unknown\'.", "165548477"]
],
"src/script/view_model/panel/AddParticipantsViewModel.ts:4264095902": [
[102, 4, 21, "Type \'ObservableArray<never>\' is not assignable to type \'ObservableArray<User>\'.", "2199671479"],
[103, 4, 20, "Type \'Observable<ServiceEntity | undefined>\' is not assignable to type \'Observable<ServiceEntity>\'.\\n The types returned by \'peek()\' are incompatible between these types.\\n Type \'ServiceEntity | undefined\' is not assignable to type \'ServiceEntity\'.\\n Type \'undefined\' is not assignable to type \'ServiceEntity\'.", "3275208665"],
[108, 4, 21, "Type \'PureComputed<boolean | undefined>\' is not assignable to type \'PureComputed<boolean>\'.", "3187656643"],
[196, 25, 9, "Argument of type \'undefined\' is not assignable to parameter of type \'ServiceEntity\'.", "2620553983"]
],
"src/script/view_model/panel/BasePanelViewModel.ts:1781850387": [
[57, 4, 23, "Type \'Observable<Conversation | null>\' is not assignable to type \'Observable<Conversation>\'.\\n The types returned by \'peek()\' are incompatible between these types.\\n Type \'Conversation | null\' is not assignable to type \'Conversation\'.\\n Type \'null\' is not assignable to type \'Conversation\'.", "233634092"]
],
Expand Down
67 changes: 0 additions & 67 deletions src/page/template/panel/add-participants.htm
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/page/template/wire-main.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ <h1 class="visually-hidden" data-bind="text: t('accessibility.headings.historyEx
<right-sidebar params="contentViewModel: $root, teamState: $root.repositories.team.teamState, userState: $root.repositories.user.userState"></right-sidebar>

#include('panel/conversation-participants.htm')
#include('panel/add-participants.htm')
#include('panel/message-details.htm')
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/script/components/ServiceList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ import {t} from '../util/LocalizerUtil';
import {KEY} from 'Util/KeyboardUtil';

export interface ServiceListProps {
arrow: boolean;
services: ServiceEntity[];
click: (serviceEntity: ServiceEntity) => void;
arrow: boolean;
noUnderline: boolean;
isSearching?: boolean;
mode?: MODE;
noUnderline: boolean;
services: ServiceEntity[];
}

export enum MODE {
Expand Down
Loading