runfix: Address emoji picker styles #14037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Nov 3, 2022
| @@ -33,15 +34,15 @@ interface EmojiItemProps { | |||
| const EmojiItem: FC<EmojiItemProps> = ({emoji, onClick, onMouseEnter, selectedEmoji = false}) => ( | |||
| <button | |||
| type="button" | |||
There was a problem hiding this comment.
@arjita-mitra I think this type=button is not necessary here. Is it?
There was a problem hiding this comment.
I believe it's only needed for input, am I correct?
There was a problem hiding this comment.
Oh actually I found my answer and it is needed :)
There was a problem hiding this comment.
Same for tabIndex={0}, looking like leftovers from changing the component from div to button
There was a problem hiding this comment.
Oh correct the tabindex is not needed, good catch 👍
V-Gira
approved these changes
Nov 3, 2022
I'm team css-in-js yes :) (also because it's the solution we already have baked in) |
PatrykBuniX
approved these changes
Nov 3, 2022
aweiss-dev
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the display of the emoji picker than was broken since #13493
It also modernizes the styles and migrate them to css-in-js
Before
After
