fix: Detect deleted clients when sending a message [FS-1090] #14755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There could be situations where we know of clients, but do not have a session with them. Which means that, when we try to encrypt for those clients, we will try to get the prekeys from them to which the backend will say that there are no prekeys. Previously we would just filter them out and ignore them. Now the core warns the webapp that those clients have been deleted and that the webapp should wipe them out from the DB
atomrc
changed the title
tlebon
approved these changes
Feb 27, 2023
V-Gira
approved these changes
Feb 27, 2023
Codecov Report
@@ Coverage Diff @@
## dev #14755 +/- ##
=======================================
Coverage 42.80% 42.80%
=======================================
Files 621 621
Lines 21240 21240
Branches 4885 4885
=======================================
Hits 9092 9092
Misses 10987 10987
Partials 1161 1161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be situations where we know of clients, but do not have a session with them. Which means that, when we try to encrypt for those clients, we will try to get the prekeys from them to which the backend will say that there are no prekeys. Previously we would just filter them out and ignore them. Now the core warns the webapp that those clients have been deleted and that the webapp should wipe them out from the DB
see wireapp/wire-web-packages#4914