fix: Keyboard navigation for conversations list #14764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #14764 +/- ##
=======================================
Coverage 42.86% 42.86%
=======================================
Files 621 621
Lines 21210 21219 +9
Branches 4867 4869 +2
=======================================
+ Hits 9091 9096 +5
- Misses 10963 10966 +3
- Partials 1156 1157 +1 |
atomrc
reviewed
Mar 2, 2023
| @@ -55,6 +55,7 @@ export interface ConversationListCellProps { | |||
| showJoinButton: boolean; | |||
| handleArrowKeyDown: (e: React.KeyboardEvent) => void; | |||
| isFocused?: boolean; | |||
| setDefaultFocus: () => void; | |||
There was a problem hiding this comment.
can you document what this function is supposed to do. It's not quite clear for the code itself
atomrc
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for switching conversation list when we get out from conversation list.
Prev: If we select context menu and click outside or use tab || shift + tab we going back to previous selected conversation.
Now: If we select context menu and click outside or use tab || shift + tab we selecting first conversation ( on top )