Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove immediate login for 2fa+entropy case [SQSERVICES-1709] #14767

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented Mar 1, 2023

BugSQSERVICES-1709 [Web] Mouse entropy shows up twice, once before and once after 2FA


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Listens for 2fa query key in order to disable immediate login for cases in which 2fa and entropy are both enabled, as this can lead to an error.

Solutions

recovers from immediate login errors in the case they are still uncaught
stops immediate login if 2fa query is present and entropy flag is present

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #14767 (790fdb0) into dev (3c87149) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev   #14767      +/-   ##
==========================================
+ Coverage   42.79%   42.86%   +0.07%     
==========================================
  Files         621      621              
  Lines       21245    21207      -38     
  Branches     4888     4869      -19     
==========================================
- Hits         9092     9091       -1     
+ Misses      10992    10957      -35     
+ Partials     1161     1159       -2     

@tlebon tlebon merged commit 6818212 into dev Mar 2, 2023
@tlebon tlebon deleted the fix/2fa-entropy-solution branch March 2, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants