Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not try to load deleted users on app load [FS-1607] #14794

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Mar 7, 2023

BugFS-1607 [web] Webapp is not removing deleted users for the `users` database

This changes the strategy we use to load the user availabilities and put them on the user enties.

What we did before was:

  • load all the user availabilities in DB
  • map those to locally loaded users and load missing users from the BE
    -> this would lead to querying deleted users from the server

The new strategy is:

  • load all the users from backend
  • for all those loaded users, find the availabilities in DB
    -> this way some availabilities might not be mapped, but that means they belonged to deleted users

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #14794 (c155b49) into dev (2ae0f84) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev   #14794      +/-   ##
==========================================
- Coverage   42.82%   42.81%   -0.02%     
==========================================
  Files         621      621              
  Lines       21219    21227       +8     
  Branches     4869     4870       +1     
==========================================
  Hits         9088     9088              
- Misses      10973    10981       +8     
  Partials     1158     1158              

Copy link
Contributor

@przemvs przemvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM :)

@atomrc atomrc merged commit e35708b into dev Mar 7, 2023
@atomrc atomrc deleted the fix/deleted-users branch March 7, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants