fix: leave call on conversation delete [FS-1608] #14795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykBuniX
commented
Mar 7, 2023
Comment on lines
-243
to
+245
| const leaveCall = async (conversationId: QualifiedId) => { | ||
| const conversation = this.getConversationById(conversationId); | ||
|
|
||
| if (!conversation?.isUsingMLSProtocol) { | ||
| const closeCall = async (conversationId: QualifiedId, conversationType: CONV_TYPE) => { | ||
| // There's nothing we need to do for non-mls calls | ||
| if (conversationType !== CONV_TYPE.CONFERENCE_MLS) { |
There was a problem hiding this comment.
In case of closing a call after deleting a conversation, the conversation might not be found with getConversationById as call close works asynchronously (and is fired by avs). So it's better to relay on a call conversation type.
Codecov Report
@@ Coverage Diff @@
## dev #14795 +/- ##
==========================================
- Coverage 42.82% 42.80% -0.03%
==========================================
Files 621 621
Lines 21219 21225 +6
Branches 4869 4870 +1
==========================================
- Hits 9088 9085 -3
- Misses 10973 10981 +8
- Partials 1158 1159 +1 |
thisisamir98
approved these changes
Mar 9, 2023
atomrc
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call was never ended after conversation was deleted, so end users were still able to here each other even though there was no conversation nor call visible on the UI.
This PR should fix this bug for both Proteus and MLS calls +
@wireapp/corepackage version bump.