fix: Improve message sending performances #14800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykBuniX
approved these changes
Mar 10, 2023
przemvs
reviewed
Mar 10, 2023
src/script/event/EventService.ts
Outdated
Comment on lines
139
to
140
| this.storageService.db | ||
| .table(StorageSchemata.OBJECT_STORE.EVENTS) |
There was a problem hiding this comment.
Move this to variable maybe ? You getting this table 2 times :)
Codecov Report
@@ Coverage Diff @@
## dev #14800 +/- ##
==========================================
- Coverage 42.80% 42.80% -0.01%
==========================================
Files 621 621
Lines 21225 21228 +3
Branches 4870 4871 +1
==========================================
+ Hits 9085 9086 +1
- Misses 10981 10982 +1
- Partials 1159 1160 +1 |
przemvs
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #14632 we never query individual events by their direct index (the
id).Instead we load all the events and go through them one by one until we find the matching ID (or replacing ID).
This is very suboptimal and gets slower and slower as more messages are added to the conversation.
We will still need to optimize loading quotes. But this should fix many performances problems
after.mov
before.mov
Should fix wireapp/wire-desktop#6486