Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid failed request to get all clients of a conversation #14828

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fix: Avoid failed request to get all clients of a conversation #14828

merged 2 commits into from
Mar 14, 2023

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Mar 14, 2023 •
edited

This will avoid this error from popping up when requesting clients in a conversation where we know no users

 Uncaught r: Error in $['qualified_users']: parsing [] failed, expected Array, but encountered Object

@atomrc atomrc requested review from a team and otto-the-bot as code owners March 14, 2023 09:25
@atomrc atomrc enabled auto-merge (squash) March 14, 2023 09:58
@atomrc atomrc disabled auto-merge March 14, 2023 10:03
@atomrc atomrc merged commit b6876a8 into dev Mar 14, 2023
@atomrc atomrc deleted the fix/empty-user-client-list branch March 14, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykBuniX PatrykBuniX PatrykBuniX approved these changes

@V-Gira V-Gira V-Gira approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
👕 size: S type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atomrc @PatrykBuniX @V-Gira @otto-the-bot