fix: Consider self user when computing classified domains #14831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #14831 +/- ##
==========================================
+ Coverage 42.76% 42.77% +0.01%
==========================================
Files 622 622
Lines 21265 21261 -4
Branches 4883 4881 -2
==========================================
+ Hits 9093 9095 +2
+ Misses 11011 11007 -4
+ Partials 1161 1159 -2 |
V-Gira
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
selfUserwas not considered when displaying the classified bar.Which means that if
Ais on a non-classified domain andBon a classified one,Awill, wrongly, see the conversation as classified (but it should not)