feat: user joins mls group with guest link #14832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #14832 +/- ##
==========================================
+ Coverage 42.78% 42.89% +0.10%
==========================================
Files 622 622
Lines 21257 21280 +23
Branches 4880 4886 +6
==========================================
+ Hits 9095 9127 +32
+ Misses 11003 10993 -10
- Partials 1159 1160 +1 |
przemvs
reviewed
Mar 16, 2023
PatrykBuniX
force-pushed
the
feat/user-joins-mls-group-with-guest-link
branch
from
68f4026
to
0fb2146
Compare
przemvs
reviewed
Mar 17, 2023
przemvs
reviewed
Mar 17, 2023
przemvs
reviewed
Mar 17, 2023
przemvs
reviewed
Mar 17, 2023
przemvs
reviewed
Mar 17, 2023
przemvs
approved these changes
Mar 17, 2023
atomrc
reviewed
Mar 20, 2023
| @@ -746,6 +752,46 @@ describe('ConversationRepository', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should add other self clients to mls group if user was event creator', () => { | |||
atomrc
reviewed
Mar 20, 2023
| @@ -2460,28 +2460,34 @@ export class ConversationRepository { | |||
| }); | |||
| } | |||
|
|
|||
| // Self user is a creator of the event | |||
| const isFromSelf = eventJson.from === this.userState.self().id; | |||
|
|
|||
| // Self user joins again | |||
There was a problem hiding this comment.
nope, removed it 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user receives
member-joinevent, and it's also a creator of this event, it means that user has joined by himself, therefore we need to add its other clients to mls group if conversation is using mls protocol