fix: Parse conversation roles directly from 'conversation.create' event [FS-1659] #14916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Mar 27, 2023
Comment on lines
-2397
to
-2404
| const data = await this.conversationService.getConversationById(conversationEntity); | ||
| const allMembers = [...data.members.others, data.members.self]; | ||
| const conversationRoles = allMembers.reduce<Record<string, string>>((roles, member) => { | ||
| roles[member.id] = member.conversation_role; | ||
| return roles; | ||
| }, {}); | ||
| conversationEntity.roles(conversationRoles); | ||
|
|
There was a problem hiding this comment.
This is where we fetched the conversation for a second time and then mapped the roles (this is now done in the ConversationMapper)
atomrc
commented
Mar 27, 2023
| @@ -89,10 +87,6 @@ export class ConversationRoleRepository { | |||
| } | |||
| }; | |||
|
|
|||
| readonly setConversationRoles = (conversation: Conversation, newRoles: ConversationRole[]): void => { | |||
Codecov Report
@@ Coverage Diff @@
## dev #14916 +/- ##
==========================================
+ Coverage 42.94% 42.96% +0.02%
==========================================
Files 623 623
Lines 21297 21294 -3
Branches 4891 4892 +1
==========================================
+ Hits 9145 9148 +3
+ Misses 10993 10986 -7
- Partials 1159 1160 +1 |
atomrc
changed the title
przemvs
approved these changes
Mar 27, 2023
V-Gira
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the flow for creating a conversation locally when it was create by someone else if:
conversation.createeventBut, the
conversation.createevent actually contains everything we need to also compute the roles directly.This PR removes the extra fetch request and computes the roles directly from the payload the
conversation.createevent