feat: Detect users that could not be listed on federated backends #14923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Mar 28, 2023
|
|
||
| import {User} from './User'; | ||
|
|
||
| export class PlaceholderUser extends User { |
There was a problem hiding this comment.
This class is not consumed yet but will be used in the UI to switch rendering when dealing with a placeholder
Codecov Report
@@ Coverage Diff @@
## dev #14923 +/- ##
=======================================
Coverage 42.94% 42.94%
=======================================
Files 624 625 +1
Lines 21299 21315 +16
Branches 4895 4897 +2
=======================================
+ Hits 9146 9153 +7
- Misses 10986 10995 +9
Partials 1167 1167 |
V-Gira
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add some
PlaceholderUserin the live user list that will account for users that could not be fetched on backend (because of federation backend failure).This has no UI changes yet, a follow up PR will start showing those
PlaceholderUser