feat: add button for 2fa submit [SQSERVICES-1991/ SQSERVICES-1940] #14961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #14961 +/- ##
==========================================
- Coverage 42.88% 42.87% -0.01%
==========================================
Files 630 630
Lines 21439 21446 +7
Branches 4920 4923 +3
==========================================
+ Hits 9194 9196 +2
- Misses 11078 11083 +5
Partials 1167 1167 |
atomrc
reviewed
Apr 3, 2023
src/script/auth/page/Login.tsx
Outdated
| style={{marginTop: 60}} | ||
| onCodeComplete={submitTwoFactorLogin} | ||
| data-uie-name="enter-code" | ||
| markInvalid={!!twoFactorSubmitError} | ||
| // markInvalid={!!twoFactorSubmitError} |
V-Gira
reviewed
Apr 3, 2023
src/script/auth/page/Login.tsx
Outdated
| style={{marginTop: 60}} | ||
| onCodeComplete={submitTwoFactorLogin} | ||
| data-uie-name="enter-code" | ||
| markInvalid={!!twoFactorSubmitError} | ||
| // markInvalid={!!twoFactorSubmitError} |
There was a problem hiding this comment.
Suggested change
| // markInvalid={!!twoFactorSubmitError} |
tlebon
commented
Apr 3, 2023
src/script/auth/page/Login.tsx
Outdated
| style={{marginTop: 60}} | ||
| onCodeComplete={submitTwoFactorLogin} | ||
| data-uie-name="enter-code" | ||
| markInvalid={!!twoFactorSubmitError} | ||
| // markInvalid={!!twoFactorSubmitError} |
There was a problem hiding this comment.
removed this comment/ line
atomrc
reviewed
Apr 3, 2023
| setTwoFactorSubmitError(''); | ||
| handleSubmit({...twoFactorLoginData, verificationCode: code}, []); | ||
| // Do not auto submit if already failed once |
tlebon
force-pushed
the
feat/2fa-submit-button
branch
from
8db776a
to
c05bc6d
Compare
atomrc
approved these changes
Apr 3, 2023
V-Gira
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
UI does not have appropriate user feedback to understand what happens when 2fa code is entered.
Screen.Recording.2023-04-03.at.15.01.54.mov
Solutions
Adds a button to 2fa login flow to allow blocking the UI. (first usage is submitted automatically)
Screen.Recording.2023-04-03.at.14.57.52.mov
Needs releases with:
FRIDA