Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add port to link preview, if defined (SQSERVICES-2018) #15033

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

comawill
Copy link
Contributor

@comawill comawill commented Apr 17, 2023

BugSQSERVICES-2018 [webapp] Ports are removed from Link preview


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

If a link preview is transmitted for an url with a defined port e.g. https://wire.com:8080/path the displayed url in the preview box will only show wire.com/path instead of wire.com:8080/path

Solutions

Include port in clearURL functionality (this is then the same behavior as on iOS).

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Send a enriched message containing a link preview, containing an URL with a port.
The Port must show up in the link preview.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #15033 (106cde6) into dev (8b9ed49) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev   #15033   +/-   ##
=======================================
  Coverage   43.39%   43.39%           
=======================================
  Files         645      645           
  Lines       21584    21584           
  Branches     4945     4946    +1     
=======================================
  Hits         9366     9366           
  Misses      11031    11031           
  Partials     1187     1187           

@tlebon tlebon merged commit 3b47b1c into dev Apr 19, 2023
@tlebon tlebon deleted the comawill/link-port branch April 19, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants