Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter unavailable users from contact list [FS-1971] #15194

Merged
merged 3 commits into from
May 17, 2023
Merged

feat: filter unavailable users from contact list [FS-1971] #15194

merged 3 commits into from
May 17, 2023

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented May 16, 2023 •
edited by github-actions bot
Loading

TaskFS-1971 [Web] Filter list of unavailable users from contact list

Issue

  • we want to filter out unavailable users from the contact list
    image

@V-Gira V-Gira requested review from a team and otto-the-bot as code owners May 16, 2023 14:45
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Merging #15194 (e90ef43) into dev (10d3e85) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

❗ Current head e90ef43 differs from pull request most recent head 6cc1f27. Consider uploading reports for the commit 6cc1f27 to get more accurate results

@@            Coverage Diff             @@
##              dev   #15194      +/-   ##
==========================================
- Coverage   43.19%   43.18%   -0.01%     
==========================================
  Files         644      644              
  Lines       21658    21660       +2     
  Branches     4960     4960              
==========================================
- Hits         9355     9354       -1     
- Misses      11109    11112       +3     
  Partials     1194     1194

przemvs
przemvs reviewed May 17, 2023
View reviewed changes
src/script/page/LeftSidebar/panels/StartUI/PeopleTab.tsx Outdated
Comment on lines 106 to 108
? teamState.teamUsers()
: teamState
.teamUsers()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assing this to variable maybe ? :)

@V-Gira V-Gira merged commit fc499fa into dev May 17, 2023
10 checks passed
@V-Gira V-Gira deleted the virgile/filter-unavailable-users-from-contact-list branch May 17, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemvs przemvs przemvs approved these changes

@PatrykBuniX PatrykBuniX PatrykBuniX approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
👕 size: S type: feature / request ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@V-Gira @przemvs @PatrykBuniX @otto-the-bot