Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce self deleting message group settings in conversations [SQSERVICES-2024] #15281

Merged
merged 1 commit into from Jun 2, 2023

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented Jun 2, 2023

StorySQSERVICES-2024 [Web] Group settings for Self-Deleting Messages should respect Team Settings


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

forces conversations to respect team self-deleting message settings.

Solutions

check team settings for self-deleting messages

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #15281 (2504c2a) into dev (53e67e6) will decrease coverage by 0.04%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##              dev   #15281      +/-   ##
==========================================
- Coverage   43.22%   43.18%   -0.04%     
==========================================
  Files         646      646              
  Lines       21749    21768      +19     
  Branches     4992     5001       +9     
==========================================
  Hits         9400     9400              
- Misses      11150    11167      +17     
- Partials     1199     1201       +2     

@tlebon tlebon merged commit 998c472 into dev Jun 2, 2023
13 checks passed
@tlebon tlebon deleted the feat/enforce-selfdeleting-messages branch June 2, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants