Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean unaccepted oauth scopes [SQSERVICES-2075/SQSERVICES-2076 ] #15314

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented Jun 6, 2023

BugSQSERVICES-2075 [Web] [OAuth] OAuth Authorization Prompt requests non-displayed scopes


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Filters out unaccepted Scopes before forwarding them to the BE

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #15314 (839aca1) into dev (cee2634) will increase coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 839aca1 differs from pull request most recent head 9ba1f11. Consider uploading reports for the commit 9ba1f11 to get more accurate results

@@           Coverage Diff           @@
##              dev   #15314   +/-   ##
=======================================
  Coverage   43.18%   43.18%           
=======================================
  Files         646      646           
  Lines       21771    21773    +2     
  Branches     5002     5002           
=======================================
+ Hits         9402     9403    +1     
- Misses      11167    11168    +1     
  Partials     1202     1202           

@tlebon tlebon changed the title feat: clean unaccepted oauth scopes [SQSERVICES-2075] feat: clean unaccepted oauth scopes [SQSERVICES-2075/SQSERVICES-2076 ] Jun 6, 2023
Copy link
Contributor

@PatrykBuniX PatrykBuniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👌

@tlebon tlebon merged commit 5802031 into dev Jun 6, 2023
14 checks passed
@tlebon tlebon deleted the feat/clean-oauth-scopes branch June 6, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants