Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web and MLS group convo wasn't renamed on header when backend wa… #15381

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

arjita-mitra
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • Web and MLS group convo wasn't renamed on header when backend was off
  • The PR Description

    • Environment: Web, Foma

      STR:

      There is MLS group conversation on Forma with users

      When backend is off - Admin renames group convo

      Actual result: conversation was renamed on participant details and group list menu, but not in internal conversation header

      Expected result: conversation was renamed on all webapp layouts


Testing

Test Coverage (Optional)

  • I have added unit test to this contribution

References
  1. https://wearezeta.atlassian.net/browse/WPB-1915

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #15381 (e814c5d) into dev (4dee09b) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev   #15381      +/-   ##
==========================================
+ Coverage   43.21%   43.39%   +0.18%     
==========================================
  Files         647      647              
  Lines       21790    21791       +1     
  Branches     5003     5003              
==========================================
+ Hits         9417     9457      +40     
+ Misses      11169    11115      -54     
- Partials     1204     1219      +15     

Copy link
Contributor

@przemvs przemvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, change component creation dates to previous ;)

@arjita-mitra arjita-mitra merged commit 5e2ad60 into dev Jun 22, 2023
13 checks passed
@arjita-mitra arjita-mitra deleted the bugfix/WPB-1915 branch June 22, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants