feat: for all backup import error add a try again flow #15579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix restire button's whole area not clickable create re-usable backup file upload component
atomrc
reviewed
Aug 14, 2023
Comment on lines
+44
to
+77
| const fileInputClick = () => fileInputRef.current?.click(); | ||
|
|
||
| return ( | ||
| <> | ||
| <label className="preferences-history-backup-import-field" data-uie-name="do-backup-import" id="do-backup-import"> | ||
| <input | ||
| id="file-import-input" | ||
| ref={fileInputRef} | ||
| tabIndex={TabIndex.UNFOCUSABLE} | ||
| type="file" | ||
| accept={`.${HistoryExportConfig.FILE_EXTENSION}`} | ||
| onChange={onFileChange} | ||
| onFocus={({target}) => target.blur()} | ||
| data-uie-name="input-import-file" | ||
| aria-describedby="preferences-history-describe-2" | ||
| /> | ||
| </label> | ||
|
|
||
| <Button | ||
| variant={variant} | ||
| className={cssClassName} | ||
| role="button" | ||
| tabIndex={TabIndex.FOCUSABLE} | ||
| onKeyDown={event => handleKeyDown(event, fileInputClick)} | ||
| onClick={() => fileInputRef.current?.click()} | ||
| aria-labelledby="do-backup-import" | ||
| > | ||
| <span>{backupImportHeadLine}</span> | ||
| </Button> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export {BackupFileUpload}; |
There was a problem hiding this comment.
Good to extract that logic to a new component 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
Log in to web app (Wire · The most secure collaboration platform)
Go to Preferences
Create backup with password
Click ‘Restore’ button and select previously created backup file
Enter invalid password and try to restore
Actual outcome:
You see ‘Wrong Password’ window. When you click ‘Cancel’ button (attachment), password dialog is gone and you have to click ‘Restore’ button again.
Expected outcome:
add a try again button in the wrong password modal, clicking on it should open the file picker again.
What's new in this PR?
Issues
Solutions
Separate the input from the button
References