Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust resolution/framerates for better video experience #15582

Merged
merged 4 commits into from Aug 15, 2023

Conversation

z-dule
Copy link
Contributor

@z-dule z-dule commented Aug 11, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@z-dule z-dule requested review from otto-the-bot and a team as code owners August 11, 2023 12:07
@CLAassistant
Copy link

CLAassistant commented Aug 11, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #15582 (28135c8) into dev (a9da915) will decrease coverage by 0.06%.
Report is 26 commits behind head on dev.
The diff coverage is n/a.

❗ Current head 28135c8 differs from pull request most recent head c9156c3. Consider uploading reports for the commit c9156c3 to get more accurate results

@@            Coverage Diff             @@
##              dev   #15582      +/-   ##
==========================================
- Coverage   43.61%   43.56%   -0.06%     
==========================================
  Files         653      653              
  Lines       22244    22253       +9     
  Branches     5081     5089       +8     
==========================================
- Hits         9702     9694       -8     
- Misses      11300    11315      +15     
- Partials     1242     1244       +2     

@atomrc atomrc changed the title Adjust resolution/framerates for better video experience feat: Adjust resolution/framerates for better video experience Aug 14, 2023
@atomrc atomrc merged commit 5256f90 into dev Aug 15, 2023
12 checks passed
@atomrc atomrc deleted the feature/increase_resolution branch August 15, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants