feat: Add logs to feature config changes [WPB-1933] #15639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atomrc
commented
Aug 22, 2023
•
atomrc
commented
 WPB-1933 [MacOS?] Notification prompts received after logging in
|
Codecov Report
@@ Coverage Diff @@
## dev #15639 +/- ##
==========================================
+ Coverage 43.63% 43.78% +0.14%
==========================================
Files 668 669 +1
Lines 22627 22633 +6
Branches 5147 5145 -2
==========================================
+ Hits 9873 9909 +36
+ Misses 11502 11483 -19
+ Partials 1252 1241 -11 |
atomrc
changed the title
atomrc
force-pushed
the
fix/team-config-popup
branch
from
ab26550
to
ad0c6a4
Compare
przemvs
reviewed
Aug 23, 2023
Comment on lines
+94
to
+100
| htmlMessage: isFeatureEnabled | ||
| ? isEnforced | ||
| ? t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemEnforced', { | ||
| timeout: formatDuration(newTimeout).text, | ||
| }) | ||
| : t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemEnabled') | ||
| : t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemDisabled'), |
There was a problem hiding this comment.
I'll move this to variable to avoid complex ternary operators.
There was a problem hiding this comment.
I think it's pretty readable like this (and backed up by tests now)
There was a problem hiding this comment.
I'll go this way:
Suggested change
| htmlMessage: isFeatureEnabled | |
| ? isEnforced | |
| ? t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemEnforced', { | |
| timeout: formatDuration(newTimeout).text, | |
| }) | |
| : t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemEnabled') | |
| : t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemDisabled'), | |
| const enforcedMessage = isEnforced | |
| ? t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemEnforced', { | |
| timeout: formatDuration(newTimeout).text, | |
| }) | |
| : t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemEnabled'); | |
| htmlMessage: isFeatureEnabled | |
| ? enforcedMessage | |
| : t('featureConfigChangeModalSelfDeletingMessagesDescriptionItemDisabled'), |
atomrc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.