Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add pending icon to outgoing connection request (WPB-4849) #15894

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Sep 26, 2023

BugWPB-4849 Missing pending icon on outgoing connection request

Description

This commit addresses a backend issue where outgoing connection requests are incorrectly categorized as type 3 (1:1 conversations) instead of type 2 (connect). To work around this issue, we now utilize the "isRequest" property from the users[0] of the conversation users. This approach ensures that the conversation type is accurately represented as type 2 in the incoming list of conversations, aligning with the expected behavior.

Screenshots/Screencast (for UI changes)

Before:
image

After:
image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@thisisamir98 thisisamir98 changed the title Fix: Add pending icon to outgoing connection request (WPB-4849) fix: Add pending icon to outgoing connection request (WPB-4849) Sep 26, 2023
Copy link
Contributor

@atomrc atomrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty solid PR 💪 😎

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #15894 (80675c2) into dev (77e81f7) will decrease coverage by 0.01%.
Report is 4 commits behind head on dev.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##              dev   #15894      +/-   ##
==========================================
- Coverage   44.51%   44.51%   -0.01%     
==========================================
  Files         673      674       +1     
  Lines       22735    22740       +5     
  Branches     5170     5170              
==========================================
+ Hits        10120    10122       +2     
- Misses      11321    11324       +3     
  Partials     1294     1294              

@thisisamir98 thisisamir98 merged commit e3b130e into dev Sep 26, 2023
13 checks passed
@thisisamir98 thisisamir98 deleted the WPB-4849 branch September 26, 2023 09:31
atomrc pushed a commit that referenced this pull request Sep 26, 2023
* Fix: Add pending icon to outgoing connection request (WPB-4849)

* remove extra deps

* move isRequest logic to conversation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants