Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent long handles from causing misalignment in add users modal #15900

Merged
merged 1 commit into from Sep 28, 2023

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Sep 28, 2023

Description

Long user handles break the alignment of participants in the add users modal.
It appears flexbox is not computing the width of the truncated string correctly, even with the usual fix of assigning min-width: 0 to the wrapper div.
Assigning a width: 0 instead fixes the issue.

Screenshots/Screencast (for UI changes)

  • min-width: 0
    image

  • width: 0
    image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #15900 (46ac85d) into dev (82d43f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #15900   +/-   ##
=======================================
  Coverage   44.53%   44.53%           
=======================================
  Files         674      674           
  Lines       22758    22758           
  Branches     5175     5175           
=======================================
  Hits        10136    10136           
  Misses      11325    11325           
  Partials     1297     1297           

@V-Gira V-Gira merged commit 733c306 into dev Sep 28, 2023
19 checks passed
@V-Gira V-Gira deleted the virgile/add-people-alignment branch September 28, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants