Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typeahead menu renders multiple times #16016

Merged
merged 1 commit into from Oct 17, 2023

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Oct 17, 2023

Description

Input bar Emojis Picker and Mentions renders multiple times new DOM Element for typeahead menu. Now we render only one time typeahead menu with different id for EmojisPicker and Mentions popover.

Screenshots/Screencast (for UI changes)

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #16016 (9510900) into dev (6b34cbf) will increase coverage by 0.09%.
Report is 6 commits behind head on dev.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##              dev   #16016      +/-   ##
==========================================
+ Coverage   44.70%   44.79%   +0.09%     
==========================================
  Files         701      701              
  Lines       23303    23301       -2     
  Branches     5289     5291       +2     
==========================================
+ Hits        10417    10438      +21     
+ Misses      11528    11504      -24     
- Partials     1358     1359       +1     

@przemvs przemvs merged commit b6f4d5a into dev Oct 17, 2023
12 checks passed
@przemvs przemvs deleted the bugfix/typeahead-menu-renders-multiple-times branch October 17, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants