Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to delete gray messages (WPB-5840) #16375

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Dec 14, 2023

StoryWPB-5840 [Web] Ability to delete grey messages (messages that are not sent)

Description

This pull request addresses the implementation of a crucial feature - the ability for users to delete messages that were never sent, commonly referred to as "grey messages." The feature covers regular text messages, self-deleting messages, as well as pictures/assets that haven't been sent.

The implementation includes modifications to the message handling logic to recognize and handle unsent messages appropriately. The "Delete" option in the context menu now triggers the removal of the selected unsent message from both the user interface and the local database.

Screenshots/Screencast (for UI changes)

image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #16375 (4ecfcf6) into dev (656a26c) will decrease coverage by 0.01%.
Report is 19 commits behind head on dev.
The diff coverage is 33.33%.

❗ Current head 4ecfcf6 differs from pull request most recent head e4e2f84. Consider uploading reports for the commit e4e2f84 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16375      +/-   ##
==========================================
- Coverage   45.45%   45.44%   -0.01%     
==========================================
  Files         733      733              
  Lines       23721    23723       +2     
  Branches     5397     5398       +1     
==========================================
  Hits        10782    10782              
- Misses      11574    11575       +1     
- Partials     1365     1366       +1     

Copy link
Contributor

@PatrykBuniX PatrykBuniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisisamir98 it looks good to me, how about adding a simple test scenario that covers this one case? We can add it to deleteMessageForEveryone tests.

Copy link
Contributor

@PatrykBuniX PatrykBuniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@thisisamir98 thisisamir98 merged commit 47c05f7 into dev Dec 18, 2023
10 checks passed
@thisisamir98 thisisamir98 deleted the feat/WPB-5840 branch December 18, 2023 10:27
thisisamir98 added a commit that referenced this pull request Jan 22, 2024
* feat: add ability to delete gray messages (WPB-5840)

* test: add testing for gray message deleting
thisisamir98 added a commit that referenced this pull request Jan 22, 2024
* feat: add ability to delete gray messages (WPB-5840) (#16375)

* feat: add ability to delete gray messages (WPB-5840)

* test: add testing for gray message deleting

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants