-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to delete gray messages (WPB-5840) #16375
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #16375 +/- ##
==========================================
- Coverage 45.45% 45.44% -0.01%
==========================================
Files 733 733
Lines 23721 23723 +2
Branches 5397 5398 +1
==========================================
Hits 10782 10782
- Misses 11574 11575 +1
- Partials 1365 1366 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thisisamir98 it looks good to me, how about adding a simple test scenario that covers this one case? We can add it to deleteMessageForEveryone
tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
* feat: add ability to delete gray messages (WPB-5840) * test: add testing for gray message deleting
Description
This pull request addresses the implementation of a crucial feature - the ability for users to delete messages that were never sent, commonly referred to as "grey messages." The feature covers regular text messages, self-deleting messages, as well as pictures/assets that haven't been sent.
The implementation includes modifications to the message handling logic to recognize and handle unsent messages appropriately. The "Delete" option in the context menu now triggers the removal of the selected unsent message from both the user interface and the local database.
Screenshots/Screencast (for UI changes)
Checklist