runfix: conversation admin mutes a single call participant [WPB-5724] #16397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #16397 +/- ##
==========================================
+ Coverage 45.52% 45.57% +0.05%
==========================================
Files 732 732
Lines 23725 23746 +21
Branches 5398 5405 +7
==========================================
+ Hits 10800 10823 +23
+ Misses 11557 11549 -8
- Partials 1368 1374 +6 |
PatrykBuniX
commented
Dec 18, 2023
Comment on lines
+669
to
+689
| const isSenderAdmin = conversation.isAdmin(userId); | ||
| if (!isSenderAdmin) { | ||
| return; | ||
| } | ||
|
|
||
| const selfUserId = this.selfUser?.qualifiedId; | ||
| const selfClientId = this.selfClientId; | ||
|
|
||
| if (!selfUserId || !selfClientId) { | ||
| return; | ||
| } | ||
|
|
||
| const isSelfClientTargetted = | ||
| !!content.data.targets[selfUserId.domain]?.[selfUserId.id]?.includes(selfClientId); | ||
|
|
||
| if (!isSelfClientTargetted) { | ||
| return; | ||
| } | ||
|
|
||
| this.muteCall(call, true, MuteState.REMOTE_MUTED); | ||
| return this.processCallingMessage(conversation, event); |
There was a problem hiding this comment.
This is the main change - from now we verify whether a self client is included in targets map and whether event creator is a conversation admin.
PatrykBuniX
commented
Dec 18, 2023
| this.sendCallingMessage(conversationId, {type: CALL_MESSAGE_TYPE.REMOTE_MUTE}, {nativePush: true, recipients}); | ||
| this.sendCallingMessage( | ||
| conversationId, | ||
| {type: CALL_MESSAGE_TYPE.REMOTE_MUTE, data: {targets: recipients}}, |
There was a problem hiding this comment.
When sending a REMOTEMUTE type of calling message, we need to include targets field containing the list of clients that should be muted.
przemvs
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When muting other people in MLS conversation we need to provide a
targetslist in REMOTEMUTE type of calling event. A client that receives this event should verify whether it was meant to be muted and whether the event creator is a conversation admin.Checklist
Important details for the reviewers
(Delete this section if unnecessary)