Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: import backup from migrated db version [WPB-5906] #16400

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented Dec 19, 2023

BugWPB-5906 [Web] Backup from Prod cannot be restored on Edge

Description

Previously it was not possible to import a backup that was made on some older version of wire if there were some DB schema migration in between that version and the current one. In that case we were just throwing an "incompatible backup version error".

With this PR, importing a backup made from older version should be possible. After history is imported we will also run schema upgrade scripts to assure that all the upgrades that should have taken place during db migration while updating wire were made.

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #16400 (c185450) into dev (07763e3) will decrease coverage by 0.02%.
Report is 2 commits behind head on dev.
The diff coverage is 64.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16400      +/-   ##
==========================================
- Coverage   45.57%   45.55%   -0.02%     
==========================================
  Files         732      732              
  Lines       23746    23754       +8     
  Branches     5405     5404       -1     
==========================================
  Hits        10822    10822              
- Misses      11549    11556       +7     
- Partials     1375     1376       +1     

@PatrykBuniX PatrykBuniX marked this pull request as ready for review December 19, 2023 13:23
Copy link
Contributor

@atomrc atomrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@PatrykBuniX PatrykBuniX merged commit 75f012d into dev Dec 19, 2023
11 checks passed
@PatrykBuniX PatrykBuniX deleted the runfix/WPB-5906-migrated-db-version-backup branch December 19, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants