Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize detecting deleted conversation after a backup restore [WPB-6166] #16678

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Jan 29, 2024

SpikeWPB-6166 [Web] [4hrs] Investigate possible memory leakages due to backup restore

Description

After a successful backup restore, we try to locally delete conversations that are deleted on backend.
Previously we didn't have a way to get those deleted conversation other than querying every single conversation and checking if the response is a 404 on backend.

Now we can optimize this and query all the conversations at once and check which ones are not_found.

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@atomrc atomrc requested review from otto-the-bot and a team as code owners January 29, 2024 15:43
@atomrc atomrc changed the title perf: Optimize detecting deleted conversation after a backup restore perf: Optimize detecting deleted conversation after a backup restore [WPB-6166] Jan 29, 2024
@atomrc atomrc merged commit 48289d8 into release/q1-2024 Jan 29, 2024
10 checks passed
@atomrc atomrc deleted the fix/restore-backup branch January 29, 2024 16:16
github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
otto-the-bot added a commit that referenced this pull request Jan 29, 2024
…[WPB-6166] (#16678) (#16680)

Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants