Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid rerendering assets when new messages arrive #16754

Merged
merged 1 commit into from Feb 5, 2024

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Feb 5, 2024

Description

When a new message comes in, the last sent message visibleCallback get updated. But we could actually have this callback stable over time and avoid extra re-renderings.

Screenshots/Screencast (for UI changes)

Before

Screen.Recording.2024-02-05.at.11.37.14.mov

After

Screen.Recording.2024-02-05.at.11.38.36.mov

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@atomrc atomrc merged commit 3f35d42 into dev Feb 5, 2024
12 checks passed
@atomrc atomrc deleted the fix/re-render-assets branch February 5, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants