Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: E2EI Device status displaying #17032

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Mar 11, 2024

Description

Don't displaying E2EI device status for device details for not self user when user don't have downloaded certificate.
Don't displaying MLS Thumbprint when we don't have E2EI certificate downloadedl

Screenshots/Screencast (for UI changes)

Before:
image

Now:
image

Before:
image

Now:
image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/q1-2024@eb2dc80). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/q1-2024   #17032   +/-   ##
==================================================
  Coverage                   ?   45.90%           
==================================================
  Files                      ?      744           
  Lines                      ?    24493           
  Branches                   ?     5610           
==================================================
  Hits                       ?    11244           
  Misses                     ?    11822           
  Partials                   ?     1427           

@przemvs przemvs merged commit 068b5d1 into release/q1-2024 Mar 11, 2024
15 checks passed
@przemvs przemvs deleted the fix/e2ei-device-status-displaying branch March 11, 2024 13:22
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
* fix: E2EI Device status displaying

* improvements

* rename from not_downloaded to not_activated
otto-the-bot added a commit that referenced this pull request Mar 11, 2024
* fix: E2EI Device status displaying

* improvements

* rename from not_downloaded to not_activated

Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants