Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: address darkmode color values #17179

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Mar 28, 2024

Description

This addresses:

  • toggle sidebar button
  • folder background
  • Unread message badge
  • Selected list item background color
  • Lack of contrast of the gray font color (also fixed in a few other part of the app that went unnoticed)

Screenshots/Screencast (for UI changes)

Before:
Screenshot from 2024-03-28 17-42-49
After:
image

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Comment on lines -208 to -217

.conversations-sidebar-btn--badge {
padding: 1px 6px;
border: 1px solid var(--white);
border-radius: 5px;
background: @red-500;
color: var(--white);
font-size: @font-size-small;
font-weight: @font-weight-semibold;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block was duplicated, I moved it at a higher level

@V-Gira V-Gira merged commit 7189d27 into new-navigation Mar 28, 2024
10 checks passed
@V-Gira V-Gira deleted the v/sidebar-dark-mode branch March 28, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants