Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jump to last message WPB-6518 #17386
feat: Jump to last message WPB-6518 #17386
Changes from all commits
9cdba8b
a376465
12f4b3d
e0167f6
2143685
60cffd0
b0b8687
d901309
9f8eebe
e816ba3
702115d
531f01b
fdf3ae4
53c99e1
3f2f8cf
10cf84d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@V-Gira I see this value being copied a few times in the app. Not a topic for now, but we should have a single place where the different breakpoints are defined so we avoid hardcoding breakpoints like this (and when possible those breakpoints should not be used in favor of just relying on the natural DOM flow).
I did try to use the DOM flow to have the button placing naturally, but turns out it's not really possible to have a button that is fixed in a scrolling container sadly.
Let's try to optimize this in a followup PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see that we have lots of hardcoded breakpoints in the code, and they are different. We should define key breakpoints, and then each component should use them and introduce new ones as
theme.breakpoints.tablet - COMPONENT_CUSTOM_WIDTH_CONSTANT
etc.