Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crash when a top contact has been removed from the app #17443

Merged
merged 1 commit into from
May 22, 2024

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented May 22, 2024

Description

fixes a crash in personal accounts when someones top contact has been deleted from the app.

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 46.08%. Comparing base (f6c03e0) to head (5d4b00b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #17443   +/-   ##
=======================================
  Coverage   46.07%   46.08%           
=======================================
  Files         754      754           
  Lines       24795    24800    +5     
  Branches     5685     5687    +2     
=======================================
+ Hits        11425    11428    +3     
  Misses      11937    11937           
- Partials     1433     1435    +2     

@tlebon tlebon merged commit abcb39f into dev May 22, 2024
11 checks passed
@tlebon tlebon deleted the bug/top-connection-deleted branch May 22, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants