-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Incoming connection request is not highlighted #17449
fix: Incoming connection request is not highlighted #17449
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #17449 +/- ##
==========================================
- Coverage 46.11% 46.11% -0.01%
==========================================
Files 754 755 +1
Lines 24797 24800 +3
Branches 5685 5684 -1
==========================================
+ Hits 11436 11437 +1
Misses 11932 11932
- Partials 1429 1431 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
* fix: Incoming connection request is not highlighted * return null instead of undefined
https://wearezeta.atlassian.net/browse/WPB-4715
Description
While user send a connection request and user which got connection request click on pending request, then conversation-list-cell is not highlighted. Also Avatar now is center to the cell.
Screenshots/Screencast (for UI changes)
Before:
![image](https://private-user-images.githubusercontent.com/13432884/333171352-a75b85c4-28fb-4fef-96d9-fe6d6bbfd962.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzU0NTEsIm5iZiI6MTcyMjEzNTE1MSwicGF0aCI6Ii8xMzQzMjg4NC8zMzMxNzEzNTItYTc1Yjg1YzQtMjhmYi00ZmVmLTk2ZDktZmU2ZDZiYmZkOTYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDAyNTIzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjM2E3OTgxYzA4N2M2Y2E2NTQzYjk4MTVjZWRhZmEwZDM3MTRhNGVkMTgwMzE2MGI5YzI5NWU0MjFlZjI1NTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ADyAtTYds3LogU_AV2n7KeisQ1AgZkVPqn_8aDEUAos)
After:
![image](https://private-user-images.githubusercontent.com/13432884/333171223-e1ee7d80-bdf4-48fa-84c3-b0e6a27637ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzU0NTEsIm5iZiI6MTcyMjEzNTE1MSwicGF0aCI6Ii8xMzQzMjg4NC8zMzMxNzEyMjMtZTFlZTdkODAtYmRmNC00OGZhLTg0YzMtYjBlNmEyNzYzN2FlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDAyNTIzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA4MTQ0NWI4YTdhYzA0MTE2Y2ZhNDlmYTQ2MGU3NDc4MmIzNGY3ODIyMzdkZjY5ZmYyNGUxMzY4OTNhMWUxNWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.JZgNhYWQIbZmWL8Nk0UBpZ-XCarjq3AaMtPW6qdhTkw)
Checklist