Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incoming connection request is not highlighted #17449

Merged

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented May 23, 2024

https://wearezeta.atlassian.net/browse/WPB-4715

Description

While user send a connection request and user which got connection request click on pending request, then conversation-list-cell is not highlighted. Also Avatar now is center to the cell.

Screenshots/Screencast (for UI changes)

Before:
image

After:
image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 46.11%. Comparing base (175986b) to head (fc55917).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17449      +/-   ##
==========================================
- Coverage   46.11%   46.11%   -0.01%     
==========================================
  Files         754      755       +1     
  Lines       24797    24800       +3     
  Branches     5685     5684       -1     
==========================================
+ Hits        11436    11437       +1     
  Misses      11932    11932              
- Partials     1429     1431       +2     

Copy link
Contributor

@PatrykBuniX PatrykBuniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@przemvs przemvs merged commit 4f01bca into dev May 23, 2024
11 checks passed
@przemvs przemvs deleted the fix/WPB-4715-incoming-connection-request-is-not-highlighted branch May 23, 2024 12:45
V-Gira added a commit that referenced this pull request May 30, 2024
V-Gira pushed a commit that referenced this pull request Jun 3, 2024
* fix: Incoming connection request is not highlighted

* return null instead of undefined
V-Gira added a commit that referenced this pull request Jun 3, 2024
* fix: Incoming connection request is not highlighted

* return null instead of undefined

Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants