feat: Add app loader #17558
Merged
feat: Add app loader #17558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #17558 +/- ##
==========================================
- Coverage 46.31% 46.12% -0.19%
==========================================
Files 758 760 +2
Lines 24904 25012 +108
Branches 5714 5724 +10
==========================================
+ Hits 11535 11538 +3
- Misses 11928 12031 +103
- Partials 1441 1443 +2 |
tlebon
reviewed
Jun 14, 2024
svitovyda
reviewed
Jun 17, 2024
svitovyda
approved these changes
Jun 17, 2024
atomrc
reviewed
Jun 17, 2024
src/script/main/index.tsx
Outdated
Comment on lines
64
to
70
| const removeLoaderRoot = () => { | ||
| const loaderRoot = document.getElementById('loader-root'); | ||
| const loaderStyles = document.getElementById('loader-styles'); | ||
|
|
||
| loaderRoot?.parentNode?.removeChild(loaderRoot); | ||
| loaderStyles?.parentNode?.removeChild(loaderStyles); | ||
| }; |
There was a problem hiding this comment.
why not putting the loader inside wire-app and let react override it completely?
This way you won't have to write this code at all
There was a problem hiding this comment.
I think you could even put the style tag in there and it will be overwritten by react
atomrc
reviewed
Jun 17, 2024
src/page/loader.js
Outdated
| const userLang = navigator.language; | ||
|
|
||
| setTimeout(() => { | ||
| if (loadingMessage) { |
There was a problem hiding this comment.
let's do the getElementById here, else we are going to have a memory leak and never release the reference
|
atomrc
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-9719
Description
Display loading screen while app is not yet initialized. We displays also information while request takes more than 30s.
Screenshots/Screencast (for UI changes)
2024-06-12.11-53-08.mp4
For video delay for show message was changed to 6s.
Checklist
Important details for the reviewers
(Delete this section if unnecessary)