Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use KeyboardUtil more often #17597

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

svitovyda
Copy link
Contributor

Description

Replaced some simple custom keyboard listeners with the ones from KeyboardUtil

Screenshots/Screencast (for UI changes)

Checklist

  • PR has been self reviewed by the author;

Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 46.12%. Comparing base (a01fa21) to head (eb9801e).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17597      +/-   ##
==========================================
+ Coverage   46.11%   46.12%   +0.01%     
==========================================
  Files         760      760              
  Lines       25017    25012       -5     
  Branches     5729     5724       -5     
==========================================
+ Hits        11537    11538       +1     
+ Misses      12036    12031       -5     
+ Partials     1444     1443       -1     

@svitovyda svitovyda merged commit 1bdd3a8 into dev Jun 17, 2024
11 checks passed
@svitovyda svitovyda deleted the refactor/use-keyboard-util branch June 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants