Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: change dark mode slow indicator styles #17600

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented Jun 17, 2024

Description

Fixes the styles of slow connection indicator in the dark mode using css variables (as requested by the design team).

Screenshots/Screencast (for UI changes)

Before:
Screenshot 2024-06-17 at 18 16 17

Now:
Screenshot 2024-06-17 at 18 02 01

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

font-size: var(--font-size-small);
font-weight: var(--font-weight-semibold);
gap: 8px;
}

.slow-connection-indicator svg,
.slow-connection-indicator svg * {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be aware using this one for SVG's :(

@PatrykBuniX PatrykBuniX merged commit 05fa288 into new-navigation Jun 17, 2024
14 checks passed
@PatrykBuniX PatrykBuniX deleted the runfix/slow-connection-dark-mode-styles branch June 17, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants