feat: Improvements for Delivered state and add tests #17611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #17611 +/- ##
==========================================
- Coverage 46.16% 46.16% -0.01%
==========================================
Files 761 762 +1
Lines 25023 25023
Branches 5724 5723 -1
==========================================
- Hits 11552 11551 -1
- Misses 12025 12028 +3
+ Partials 1446 1444 -2 |
atomrc
reviewed
Jun 19, 2024
| @@ -31,7 +31,7 @@ export const messageBodyActions: CSSObject = { | |||
| minHeight: '32px', | |||
| minWidth: '40px', | |||
| position: 'absolute', | |||
| right: '16px', | |||
| right: '-40px', | |||
There was a problem hiding this comment.
can you explain what is happening here 🤔
Feels like a weird value
There was a problem hiding this comment.
It's like that there, because there is added new container, and this MessageActions is displayed on message-body, not on whole container.
atomrc
reviewed
Jun 19, 2024
src/script/components/MessagesList/Message/ContentMessage/ContentMessage.tsx
Outdated
Show resolved
Hide resolved
|
przemvs
changed the title
atomrc
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added data-uie-values for qa for check if delivery message is working correctly.
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)