Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: Improve background edge blurring #17615

Merged
merged 3 commits into from
Jun 19, 2024
Merged

runfix: Improve background edge blurring #17615

merged 3 commits into from
Jun 19, 2024

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Jun 19, 2024

Description

We were previously trying to manually do a smoothing of the edge detected by the segmenter.
But turned out the result of the segmentation is already a float value that gives how much of the clear pixel should be used compared to the blurred pixel.

So instead of manually computing a smooth value, we can just use the segmenter's raw value

Screenshots/Screencast (for UI changes)

Before

image

After

image

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.17%. Comparing base (74d04e5) to head (51d64ab).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17615      +/-   ##
==========================================
+ Coverage   46.16%   46.17%   +0.01%     
==========================================
  Files         761      762       +1     
  Lines       25023    25023              
  Branches     5724     5723       -1     
==========================================
+ Hits        11552    11555       +3     
  Misses      12025    12025              
+ Partials     1446     1443       -3     

Copy link

sonarcloud bot commented Jun 19, 2024

Copy link
Contributor

@PatrykBuniX PatrykBuniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding!

@atomrc atomrc merged commit a827511 into dev Jun 19, 2024
11 checks passed
@atomrc atomrc deleted the fix/better-blur branch June 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants