feat: clear inactive streams when participant connection is closed #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
suggested changes
May 22, 2018
| const audio = this.remote_media_streams.audio; | ||
|
|
||
| video(video().filter(stream => !streamIds.includes(stream.id))); | ||
| audio(audio().filter(stream => !streamIds.includes(stream.id))); |
There was a problem hiding this comment.
You are in the scope of observable arrays. You can just do:
const streamIds = streams.map(stream => stream.id);
this.remote_media_streams.audio.remove(stream => streamIds.includes(stream.id));
this.remote_media_streams.video.remove(stream => streamIds.includes(stream.id));
atomrc
force-pushed
the
gvc/memory_release
branch
5 times, most recently
from
66fde13
to
013575e
Compare
atomrc
force-pushed
the
gvc/memory_release
branch
from
013575e
to
67d9cf3
Compare
gregor
approved these changes
May 23, 2018
| } else { | ||
| connectionMediaStreamTracks = peerConnection | ||
| .getRemoteStreams() | ||
| .reduce((tracks, stream) => tracks.concat(stream.getTracks()), []); |
There was a problem hiding this comment.
const connectionMediaStreamTracks = peerConnection.getReceivers
? peerConnection.getReceivers().map(receiver => receiver.track)
: peerConnection.getRemoteStreams().reduce((tracks, stream) => tracks.concat(stream.getTracks()), []);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.