feat: switches for input devices #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yserz
approved these changes
May 25, 2018
atomrc
reviewed
May 25, 2018
app/page/template/video-calling.htm
Outdated
| type: z.media.MediaDeviceType.VIDEO_INPUT"> | ||
| </device-toggle-button> | ||
| <!-- /ko --> | ||
| <!-- ko ifnot: showSwitchCamera --> |
There was a problem hiding this comment.
Just for consistency, can we try to call the showSwitchCamera observable always the same way.
Either showSwitchCamera() or showSwitchCamera.
There was a problem hiding this comment.
Maybe showSwitchCamera() would be better, so that we don't, when reading the code, testing that the observable exists with testing the actual value of the observable.
atomrc
requested changes
May 25, 2018
app/page/template/video-calling.htm
Outdated
| type: z.media.MediaDeviceType.VIDEO_INPUT"> | ||
| </device-toggle-button> | ||
| <!-- /ko --> | ||
| <!-- ko ifnot: showSwitchCamera --> |
There was a problem hiding this comment.
Maybe showSwitchCamera() would be better, so that we don't, when reading the code, testing that the observable exists with testing the actual value of the observable.
| return this.isCallOngoing() && isVisible; | ||
| }); | ||
| this.showSwitchScreen = ko.pureComputed(() => { | ||
| const hasMultipleCameras = this.availableDevices.screen_input().length > 1; |
There was a problem hiding this comment.
hasMultipleCameras => hasMultipleScreens
atomrc
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.