Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to unicode 11 standard for inclusion of addtional emoji #4466

Merged
merged 2 commits into from Sep 10, 2018

Conversation

maximbaz
Copy link
Contributor

Hello, it's your Emoji Ambassador again 馃槣

It's time to update to Unicode 11 standard and add whooping 66 new emojis to Wire 馃帀

Update procedure didn't change, let me just recap it for documentation purposes:

  • Pull emojione/eac.json file, format it with prettier and save in app/image/emoji.json.
  • Follow the instructions in app/script/util/EmojiUtil.js on how to update Unicode ranges in both app/script/util/EmojiUtil.js and app/style/common/variables.less.

Although I'm pretty confident in this PR, unfortunately I couldn't test this and I couldn't add some screenshots, I'm having troubles authenticating in local instance just like #4414:

I would appreciate a hint on how to login with email and password so that I could test this 馃槈

@gregor
Copy link
Contributor

gregor commented Aug 31, 2018

@maximbaz Thanks for updating this.

Seems like our documentation on running the app locally is outdated. Since we added a react login page we have to make use of a proxy. I will update the documentation.

The page you should navigate to is http://localhost:8080/page/auth.html. Login with a public account will work with http://localhost:8080/page/auth.html?env=prod. Maybe not all redirects are working as intended. Once you did log in, you can go to http://localhost:8080/app?env=prod if the redirect does not work for the production account.

@gregor
Copy link
Contributor

gregor commented Aug 31, 2018

The mentioned issue with our documentation is addressed by #4468

@maximbaz
Copy link
Contributor Author

Thanks for the hint on how to run the app locally.

Seems good, ready for merge, as usual ping me if you discover some bugs in your own testing 馃槈

wire-emoji11

@gregor gregor changed the title Emoji: update to Unicode 11 standard feat: Update to unicode 11 standard for inclusion of addtional emoji Sep 10, 2018
@gregor gregor merged commit 531f4bb into wireapp:dev Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants