test: Bootstrap test cases for the SDPMapper class #4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Sep 11, 2018
| @@ -124,6 +124,6 @@ z.calling.SDPMapper = { | |||
|
|
|||
| sessionDescription = sdpLines.join('\r\n'); | |||
| const sdpInit = {sdp: sessionDescription, type}; | |||
| return Promise.resolve({iceCandidates, sdp: sdpInit}); | |||
There was a problem hiding this comment.
Noticeable change, I decide to remove the promise wrapping of the result.
Since it is not needed here (nothing async), it feels more natural and the api is easier to use
atomrc
force-pushed
the
test/sdp_mapper_tests
branch
from
6315767
to
55cf6bf
Compare
atomrc
changed the title
atomrc
force-pushed
the
test/sdp_mapper_tests
branch
from
43121f1
to
414d768
Compare
atomrc
force-pushed
the
test/sdp_mapper_tests
branch
from
414d768
to
8296215
Compare
bennycode
reviewed
Sep 13, 2018
| negotiationMode: () => '', | ||
| }; | ||
|
|
||
| // local SDP |
There was a problem hiding this comment.
I think we can remove that comment because {sdp: localSdp} make already clear that it is the local SDP. Same applies to the remoteSdp.
bennycode
approved these changes
Sep 13, 2018
|
LGTM |
gregor
pushed a commit
that referenced
this pull request
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.