fix: Non team accounts should not see guest banner (WEBAPP-5438) #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
commented
Sep 21, 2018
| @@ -81,7 +81,8 @@ z.entity.Conversation = class Conversation { | |||
| this.is_self = ko.pureComputed(() => this.type() === z.conversation.ConversationType.SELF); | |||
|
|
|||
| this.hasGuest = ko.pureComputed(() => { | |||
| return this.is_group() && this.participating_user_ets().some(userEntity => userEntity.isGuest()); | |||
| const hasGuestUser = this.participating_user_ets().some(userEntity => userEntity.isGuest()); | |||
| return hasGuestUser && this.is_group() && this.self.inTeam(); | |||
There was a problem hiding this comment.
Logical change that checks whether the self user is a team account.
gregor
force-pushed
the
bug/WEBAPP-5438
branch
from
f39cf4f
to
260f158
Compare
gregor
commented
Sep 21, 2018
| ONE2ONE: 2, | ||
| REGULAR: 0, |
There was a problem hiding this comment.
I have tripped over this naming many times. This makes a lot more sense.
ffflorian
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.